Skip to content

Conversation

@nimrof
Copy link
Collaborator

@nimrof nimrof commented Feb 1, 2025

resolves #163

@nimrof nimrof added the bug Something isn't working label Feb 1, 2025
@nimrof nimrof self-assigned this Feb 1, 2025
@nimrof nimrof linked an issue Feb 1, 2025 that may be closed by this pull request
Copy link
Collaborator

@trojanobelix trojanobelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment still says."ODEntry constructor for array subobjects" / Parameter "nosubindex" not used

@nimrof
Copy link
Collaborator Author

nimrof commented Feb 3, 2025

Comment still says."ODEntry constructor for array subobjects" / Parameter "nosubindex" not used

You are correct, but that is outside of the scope of the issue and i can use many hours trying to fix all that is wrong.

Me personally have given up on fixing the nice-to-have functions connected to eds file for now, and am instead focusing on the new gui that will have much of the same functions, but hopefully better separated from the read/write a format code.
When that is done i very much would like to remove the nice-to-have functions from the eds and clean it up.
Its a little related to this comment #137 (comment)

@nimrof nimrof merged commit 018dbdf into main Feb 3, 2025
4 checks passed
@nimrof nimrof deleted the 163-objecttype-odentry-constructor-for-array-subobjects branch February 3, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

objecttype ODEntry constructor for array subobjects

3 participants